From address erroneously set from x-original-to header

#202

Here are the full headers that resulted in the email from address set to "aquamacs-devel@aquamacs.org" instead of my subscribed address "alan.schmitt@polytechnique.org" when I replied.

Mime-Version: 1.0 (Apple Message framework v1251.1)
From: David Reitter <david.reitter@gmail.com>
In-Reply-To: <E7BBB5C9-0323-425F-911F-3B4B049296B3@polytechnique.org>
Date: Sun, 25 Dec 2011 18:44:14 +0100
Message-Id: <E94B27CB-942E-4434-ACDE-624C3E53C92C@gmail.com>
References: <E7BBB5C9-0323-425F-911F-3B4B049296B3@polytechnique.org>
To: Aquamacs Developers <aquamacs-devel@aquamacs.org>
Subject: Re: [Aquamacs-devel] Building aquamacs24 with no added package
Precedence: list
Reply-To: Aquamacs Developers <aquamacs-devel@aquamacs.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: aquamacs-devel-bounces@aquamacs.org
Errors-To: aquamacs-devel-bounces@aquamacs.org

Reported by Alan Schmitt · December 26th, 2011 @ 05:32 PM

Activity

benny
- State changed from new to reproduced
- Assigned user set to benny
I am going to try to fix this by doing two things when deriving a From address:
- Cross-check all email addresses found in delivery related headers AND the 'for' part of Received headers with addresses explicitly configured in the account settings. The first one found is used.
- Otherwise use X-Original-To if available, but never rely on a X-Original-To header if a Delivered-To header is added later.
At least that is what I'm considering right now. It would work for the example in this ticket where the correct address only appears in a Received header:
```
Received: from relay.andrew.cmu.edu (RELAY-02.ANDREW.CMU.EDU [128.2.10.85])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx2.polytechnique.org (Postfix) with ESMTPS id 89DAB803285
 for <alan.schmitt@polytechnique.org>; Sun, 25 Dec 2011 18:44:54 +0100 (CET)
```
December 27th, 2011 @ 02:00 PM
benny
- State changed from reproduced to fixcommitted
You can hold down ⌥ while clicking “Check Now” in the “Software Update” preferences pane. That should give you r2670 with a fix, but it has not been tested much. (In general, any version obtained via ⌥ should not be considered stable. They are most often debug versions.)

Thanks in advance for trying it.

The fix involves the first item in the previous comment to this ticket.

January 5th, 2012 @ 04:30 PM
Alan Schmitt
I will give it a try, but as I'm not currently using MailMate as my default mail program, it may take a few days.

January 9th, 2012 @ 10:15 AM
Alan Schmitt
I have just tried and I confirm this fixes my problem. Thanks!

January 11th, 2012 @ 08:36 AM

Alan Schmitt

I think I found another instance where this fails (using version 2679). Here are the headers:

Return-Path: celtique-owner@listes.irisa.fr
Received: from zfront1.inria.fr (LHLO zfront1.inria.fr) (193.51.193.147) by
 zmbs2.inria.fr with LMTP; Tue, 3 Jan 2012 11:44:23 +0100 (CET)
Received: from mail1-relais-roc.national.inria.fr (mail1-relais-roc.national.inria.fr [192.134.164.82])
    by zfront1.inria.fr (Postfix) with ESMTPS id 06286238035;
    Tue,  3 Jan 2012 11:45:53 +0100 (CET)
X-IronPort-AV: E=Sophos;i="4.71,449,1320620400"; 
   d="scan'208";a="137636404"
Received: from listes.irisa.fr ([131.254.254.47])
  by mail1-relais-roc.national.inria.fr with ESMTP; 03 Jan 2012 11:45:52 +0100
Received: by listes.irisa.fr (Postfix, from userid 108)
    id B91DE2EA5DA; Tue,  3 Jan 2012 11:45:52 +0100 (CET)
X-Original-To: celtique@listes.irisa.fr
Delivered-To: celtique@listes.irisa.fr
Received: from mail4-relais-sop.national.inria.fr (mail4-relais-sop.national.inria.fr [192.134.164.105])
    by listes.irisa.fr (Postfix) with ESMTP id A2FFD1DA099
    for <celtique@listes.irisa.fr>; Tue,  3 Jan 2012 11:45:50 +0100 (CET)
X-IronPort-AV: E=Sophos;i="4.71,449,1320620400"; 
   d="scan'208";a="125391782"
Received: from cbg35-2-78-242-14-140.fbx.proxad.net (HELO [192.168.0.145]) ([78.242.14.140])
  by mail4-relais-sop.national.inria.fr with ESMTP/TLS/AES128-SHA; 03 Jan 2012 11:45:50 +0100
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Apple Message framework v1251.1)
From: Alan Schmitt <alan.schmitt@inria.fr>
In-Reply-To: <4F02D746.60206@irisa.fr>
Date: Tue, 3 Jan 2012 11:45:50 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <E4FC956C-2BD1-4AA1-9DF4-1E4FBE16087F@inria.fr>
References: <4F02D746.60206@irisa.fr>
To: celtique@listes.irisa.fr
X-Mailer: Apple Mail (2.1251.1)
Subject: [CELTIQUE] =?ISO-8859-1?Q?Re:_before_th=E8se?=
X-Loop: celtique@listes.irisa.fr
X-Sequence: 316
Errors-to: celtique-owner@listes.irisa.fr
Precedence: list
X-no-archive: yes
List-Id: <celtique.listes.irisa.fr>
List-Archive: <http://listes.irisa.fr/wws/arc/celtique>
List-Help: <mailto:sympa@listes.irisa.fr?subject=help>
List-Owner: <mailto:celtique-request@listes.irisa.fr>
List-Post: <mailto:celtique@listes.irisa.fr>
List-Subscribe: <mailto:sympa@listes.irisa.fr?subject=subscribe%20celtique>
List-Unsubscribe: <mailto:sympa@listes.irisa.fr?subject=unsubscribe%20celtique>

When I do a "reply", the From address is set to "celtique@listes.irisa.fr".

January 13th, 2012 @ 11:23 AM

benny
There is only one header with your address:
```
From: Alan Schmitt <alan.schmitt@inria.fr>
```
But I assume that is only because you wrote the message.

The only fix I can think of is to ignore the X-Original-To header if it was added before any Received headers. There is a test build with that change now. Release notes:
- Improved From address derivation. Now any X-Original-To or X-Delivered-To headers are ignored if they come after any Received headers.
January 13th, 2012 @ 12:37 PM
Alan Schmitt
Yes, I wrote the message I was replying to.

I tested it and it works. Thanks!

January 13th, 2012 @ 12:49 PM
benny
- State changed from fixcommitted to fixreleased
[bulk edit]

March 21st, 2012 @ 04:40 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.