Issue with smart mailbox to mimic watch function using thread-id is in...

Quick guess: Try “Tags/Keywords include Watched”. Currently you are matching messages only with the Watched tag and no other tags (I know, MailMate shouldn't make it easy to make this mistake).

I might not get you previous comment... I have two rules so the first one is only to match the watch message "All messages with the watch TAG", screen shot 04.png and .44.png. For this one if I change it to tags/keyword rather than tags it select exactly the same messages.

The second rule uses the first rule to select messages with the same thread IDs in the tagged messages. The above change did not change it, it does not show any NEW message threads I tag, however it does show message that I've tagged before the "bug" got introduced.

(In any case, use the “Tags/Keywords” variant.)

Send me the following file:

/Users/<username>/Library/Application Support/MailMate/Mailboxes.plist

And I'll try to reproduce the issue.

Found some more interesting stuff when playing with this.

If I select the thread in my mailbox you can see the arc only shows a single message? Where the screen show a list of messages in this thread.
No when I select them with the thread icon, I see 0 messages, not even the original I was on (pic2).

Might this be a hint? I'll sent you the requested file by email.

Yes, that is a hint. You should check the location of these emails using the “Source Mailbox” column in the message list. Then make sure that these mailboxes are included when switching to “All Messages” (deleted and junk are not included). Also check that you don't have any conditions on the All Messages mailbox which might leave them out.

Let's focus on this search issue since it's likely what is triggering the other issue.

Also check your Default Mailbox setting in the toolbar search menu.

The two pictures (pic1/2) are from the mailbox these messages are in, so they look already wrong in the original mailbox.

However, if I go to my smart mailbox, and disable the conditions, the mail missing shows up (almost all my mails show up ;). When applying it again it's gone.

Just to add more I have several real mailboxes that show threaded messages, however, I only see a single DOT in the thread Arcs. If I tag such message it is not showing up in the smartmailbox.

So it's got something to do with specific threads not being recognized by the Arc drawing, but are shown as threads in the message view for the mailbox.

Any update? I also noticed this is specific to the message (thread), so for this mailinglist it happens only for some messages. I found the following message which I marked for watching is not showing up in the combined one:

Return-Path: ovs-dev-bounces@openvswitch.org
Received: from XXXX.com (LHLO
XXXX.com) (10.5.81.11) by XXXX.com with LMTP; Mon, 25 Feb 2019 11:23:31 -0500 (EST) Received: from
by (Postfix) with ESMTP id 7825FDA127 for <>; Mon, 25 Feb 2019 11:23:31 -0500 (EST) Received: by (Postfix)
id 6D6521018A24; Mon, 25 Feb 2019 16:23:31 +0000 (UTC) Delivered-To:
Received:
Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by xxxx.com (Postfix) with ESMTPS id 1D3895946B; Mon, 25 Feb 2019 16:22:57 +0000 (UTC) Received: from mail.linux-foundation.org (localhost [127.0.0.1])
by mail.linuxfoundation.org (Postfix) with ESMTP id 22FD05D58; Mon, 25 Feb 2019 16:22:47 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org
Delivered-To: ovs-dev@mail.linuxfoundation.org
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
[172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 437AB5CAC for ovs-dev@openvswitch.org; Mon, 25 Feb 2019 16:17:34 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by smtp1.linuxfoundation.org (Postfix) with ESMTPS id E02E378C for ovs-dev@openvswitch.org; Mon, 25 Feb 2019 16:17:33 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Feb 2019 08:17:33 -0800 X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.58,411,1544515200"; d="scan'208";a="137050681"
Received: from silpixa00399779.ir.intel.com (HELO
silpixa00399779.ger.corp.intel.com) ([10.237.222.34]) by orsmga002.jf.intel.com with ESMTP; 25 Feb 2019 08:17:31 -0800 From: Harry van Haaren harry.van.haaren@intel.com
To: ovs-dev@openvswitch.org
Date: Mon, 25 Feb 2019 16:18:12 +0000
Message-Id: 20190225161815.59733-1-harry.van.haaren@intel.com
In-Reply-To: 20190121132241.76471-1-harry.van.haaren@intel.com
References: 20190121132241.76471-1-harry.van.haaren@intel.com
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI
autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
smtp1.linux-foundation.org Cc: i.maximets@samsung.com
Subject: [ovs-dev] [PATCH 0/3] dpcls subtable func pointers
X-BeenThere: ovs-dev@openvswitch.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id:
List-Unsubscribe: https://mail.openvswitch.org/mailman/options/ovs-dev,
ovs-dev-request@openvswitch.org?subject=unsubscribe List-Archive: http://mail.openvswitch.org/pipermail/ovs-dev/
List-Post: ovs-dev@openvswitch.org
List-Help: ovs-dev-request@openvswitch.org?subject=help
List-Subscribe: https://mail.openvswitch.org/mailman/listinfo/ovs-dev,
ovs-dev-request@openvswitch.org?subject=subscribe MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ovs-dev-bounces@openvswitch.org
Errors-To: ovs-dev-bounces@openvswitch.org
X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 216 matched, not delayed by milter-greylist-4.5.16 (xxx.com []); Mon, 25 Feb 2019 16:22:58 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (xxx.com [10.5.110.39]); Mon, 25 Feb 2019 16:22:58 +0000 (UTC) for IP:'140.211.169.12' DOMAIN:'mail.linuxfoundation.org' HELO:'mail.linuxfoundation.org' FROM:'ovs-dev-bounces@openvswitch.org' RCPT:''
X-xxx-Spam-Score: -3.301 (HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS) 140.211.169.12 mail.linuxfoundation.org 140.211.169.12 mail.linuxfoundation.org ovs-dev-bounces@openvswitch.org
X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22

Hi Folks,

TL;DR: Dropped optimized dpcls_rule_match_key() to simplify this
patchset, optimization patches will depend on this patchset's
functionality once it is integrated.

I've run with make check, and its showing good here now.

This patchset makes the following changes;

Patch 1:
Refactor dpcls_lookup and the subtable for flexibility.
In particular, add a function pointer to the subtable
structure, which enables "plugging-in" a lookup function
at runtime. This enables a number of optimizations in future.

Patch 2 & 3:
With the function pointer in place, we refactor the existing
dpcls_lookup matching code into its own function, and later its
own file. To split it to its own file requires making various
dpcls data-structures available in the dpif-netdev.h header.

Regards, -Harry

Harry van Haaren (3):
dpif-netdev: implement function pointers/subtable dpif-netdev: move dpcls lookup structures to .h dpif-netdev: split out generic lookup function

lib/automake.mk | 1 + lib/dpif-netdev-lookup-generic.c | 95 +++++++++++++++++++++++++++ lib/dpif-netdev.c | 108 ++++--------------------------- lib/dpif-netdev.h | 66 +++++++++++++++++++ 4 files changed, 175 insertions(+), 95 deletions(-) create mode 100644 lib/dpif-netdev-lookup-generic.c

2.17.1

dev mailing list
dev@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev