URLs containing punctuation not parsed properly
-
benny
- State changed from new to bluesky
I was able to reproduce it. It's a classic problem with URLs in text and I've fixed it to work for your and similar examples. The only problem is that it won't work if the URL ends with a
). This is a tricky special case which I'm postponing fixing indefinitely. -
David Shepherdson
That sounds great -- thanks Benny!
However, I notice that my original report may have been slightly misleading (so what you fixed was, I think, a more complicated case than I was intending to report!). I didn't realise that the Lighthouse site would parse and format the text I'd entered, meaning that the actual message containing the URL didn't come through as clearly as I'd expected.
Now I understand that, here's the actual text I was trying to show:
See <http://jenkins.example.com/job/Product%20XXX-15642%20(UI%20Changes)%20Build/3/changes>So in this case, what surprised me was that MailMate wasn't picking up that everything between angle brackets would be the URL -- I had anticipated that it would be a fairly straightforward fallback case of 'everything from the opening angle bracket to the closing angle bracket should be interpreted as part of the URL'.
Just thought I'd better clarify this, in case it makes a difference to the implementation!
Thanks Benny,
David
-
benny
Thanks for the clarification, but it was a good thing that I fixed it for whether or not the brackets are present :-)
-
Erik M-H
So, Benny, is proper parsing of URLs ending in “)” still blue-sky?
I ask specifically because I run into this about once a week in MailMate Markdown with Wikipedia article URLs, such as
http://en.wikipedia.org/wiki/The_Imitation_Game_(play).
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.